Skip to content

PR CI (x86_64-gnu-llvm-17) does not run codegen tests #126170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikic opened this issue Jun 8, 2024 · 1 comment · Fixed by #126173
Closed

PR CI (x86_64-gnu-llvm-17) does not run codegen tests #126170

nikic opened this issue Jun 8, 2024 · 1 comment · Fixed by #126173
Labels
A-CI Area: Our Github Actions CI C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@nikic
Copy link
Contributor

nikic commented Jun 8, 2024 •
edited
Loading

https://github.com/rust-lang/rust/blob/master/src/ci/docker/scripts/x86_64-gnu-llvm.sh passes --skip tests/codegen if ENABLE_GCC_CODEGEN is enabled. The tests are disabled when using the LLVM backend as well.
@nikic nikic added the C-bug Category: This is a bug. label Jun 8, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 8, 2024
@nikic nikic mentioned this issue Jun 8, 2024
Merged
@nikic nikic added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jun 8, 2024
@jieyouxu jieyouxu added A-CI Area: Our Github Actions CI and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 8, 2024
@nikic
Copy link
Contributor Author

nikic commented Jun 8, 2024

This is less bad than I initially thought because ENABLE_GCC_CODEGEN is only enabled in PR CI, so we still at least check this in auto CI.

@nikic nikic mentioned this issue Jun 8, 2024
Merged
@bors bors closed this as completed in 6c4755d Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't disable codegen tests in PR CI nikic/rust
3 participants
@nikic @jieyouxu @rustbot