Skip to content

run-make tests not forcibly re-run if the run-make-support library is modified #122961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Mar 23, 2024 · 0 comments · Fixed by #122962
Closed

run-make tests not forcibly re-run if the run-make-support library is modified #122961

jieyouxu opened this issue Mar 23, 2024 · 0 comments · Fixed by #122962
Assignees
@jieyouxu
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

Current workaround is to ./x test tests/run-make --force-rerun.
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Mar 23, 2024
@jieyouxu jieyouxu self-assigned this Mar 23, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 23, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 23, 2024
@jieyouxu jieyouxu mentioned this issue Mar 23, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 24, 2024
@matthiaskrgr
Rollup merge of rust-lang#122962 - jieyouxu:stamp-rmake-support-lib, …
b834ca8 
…r=onur-ozkan

Track run-make-support lib in common inputs stamp

So that when the support library gets modified, `run-make` tests are forced to re-run instead of being still ignored as if nothing changed.

Fixes rust-lang#122961.
@bors bors closed this as completed in 5281fe2 Mar 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 24, 2024
@rust-timer
Unrolled build for rust-lang#122962
34487a8 
Rollup merge of rust-lang#122962 - jieyouxu:stamp-rmake-support-lib, r=onur-ozkan

Track run-make-support lib in common inputs stamp

So that when the support library gets modified, `run-make` tests are forced to re-run instead of being still ignored as if nothing changed.

Fixes rust-lang#122961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track run-make-support lib in common inputs stamp jieyouxu/rust
2 participants
@jieyouxu @rustbot