bootstrap doesn't retry downloads that fail with a non-HTTP error

[jyn514]

We're passing --retry:

rust/src/bootstrap/download.rs

Line 220 in b80ee39

"--retry",

but by default that only retries 500 errors, not any error: https://everything.curl.dev/usingcurl/downloads/retry#retry-on-any-and-all-errors

Originally posted by @jyn514 in #109875 (comment)

[jyn514]

This is a regression from when I moved the downloads from python to rust (about a year ago now I think).

[albertlarsan68]

Mentoring instructions:

Add the --retry-all-errors option to the curl invocations, in

rust/src/bootstrap/bootstrap.py

Line 95 in b80ee39

"--retry", "3", "-Sf", url],

and

rust/src/bootstrap/download.rs

Line 220 in b80ee39

"--retry",

This doesn't affect the Windows Powershell fallback, since we already retry on any error.
There are many other curl invocations across the repo, but they seem to not be causing problems.

[kayagokalp]

@rustbot claim

[onur-ozkan]

This is quite new flag shipped with recent versions of curl, which is not supported on many machines/platforms(including our CI runners).

We can consider using --retry-connrefused as I also suggest at #110245 (comment)