Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ad211ced81509462cdfe4c29ed10f97279a0acae
Choose a base ref
...
head repository: rust-lang/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 07074990a9334629d479cdc80d2ed1f7e6bc78ea
Choose a head ref
  • 18 commits
  • 43 files changed
  • 7 contributors

Commits on Dec 4, 2024

  1. Configuration menu
    Copy the full SHA
    baf4bb7 View commit details
    Browse the repository at this point in the history
  2. add assert

    lcnr committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    1228b38 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2025

  1. Configuration menu
    Copy the full SHA
    b579c36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    087b872 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c3132e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8cefc0a View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2025

  1. Failing test

    compiler-errors committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    ab07e78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86d8b79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a56600 View commit details
    Browse the repository at this point in the history
  4. rustdoc: use stable paths as preferred canonical paths

    This accomplishes something like 16a4ad7,
    but with the `rustc_allowed_through_unstable_modules` attribute instead
    of the path length.
    notriddle committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    c7a806a View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2025

  1. Configuration menu
    Copy the full SHA
    b77eb96 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of #133810 - lcnr:remove-verify_bound, r=compiler-errors

    remove unnecessary `eval_verify_bound`
    
    This does not impact any tests. I feel like any cases where this could useful should instead be fixed by a general improvement to `eval_verify_bound` to avoid having to promote this `TypeTest` in the first place 🤔
    
    r? types cc ``@nikomatsakis``
    matthiaskrgr authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    191fb23 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of #134745 - compiler-errors:better-arg-span-in-typeck, …

    …r=BoxyUwU
    
    Normalize each signature input/output in `typeck_with_fallback` with its own span
    
    Applies the same hack as #106582 but to the args in typeck. Greatly improves normalization error spans from a signature.
    matthiaskrgr authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    c371a94 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of #134989 - max-niederman:guard-patterns-hir, r=oli-obk

    Lower Guard Patterns to HIR.
    
    Implements lowering of [guard patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see the [tracking issue](#129967)) to HIR.
    matthiaskrgr authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    a20d0d5 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of #135149 - compiler-errors:mangle, r=oli-obk

    Use a post-monomorphization typing env when mangling components that come from impls
    
    When mangling associated methods of impls, we were previously using the wrong param-env. Instead of using a fully monomorphized param-env like we usually do in codegen, we were taking the post-analysis param-env, and treating it as an early binder to *re-substitute* the impl args. I've pointed out the problematic old code in an inline comment.
    
    This would give us param-envs with possibly trivial predicates that would prevent normalization via param-env shadowing.
    
    In the example test linked below, `tests/ui/symbol-names/normalize-in-param-env.rs`, this happens when we mangle the impl `impl<P: Point2> MyFrom<P::S> for P` with the substitution `P = Vec2`. Because the where clause of the impl is `P: Point2`, which elaborates to `[P: Point2, P: Point, <P as Point>::S projects-to <P as Point2>::S2]` and the fact that `impl Point2 for Vec2` normalizes `Vec2::S2` to `Vec2::S`, this causes a cycle.
    
    The proper fix here is to use a fully monomorphized param-env for the case where the impl is properly substituted.
    
    Fixes #135143
    
    While #134081 uncovered this bug for legacy symbol mangling, it was preexisting for v0 symbol mangling. This PR fixes both. The test requires a "hack" because we strip the args of the instance we're printing for legacy symbol mangling except for drop glue, so we box a closure to ensure we generate drop glue.
    
    r? oli-obk
    matthiaskrgr authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    3e12d4d View commit details
    Browse the repository at this point in the history
  6. Rollup merge of #135171 - notriddle:notriddle/stable-path-is-better, …

    …r=GuillaumeGomez
    
    rustdoc: use stable paths as preferred canonical paths
    
    This accomplishes something like 16a4ad7, but with the `rustc_allowed_through_unstable_modules` attribute instead of the path length.
    
    Fixes #131676
    matthiaskrgr authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    0e48e96 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of #135200 - jieyouxu:stabilize-style-edition, r=ytmimi,…

    …compiler-errors
    
    rustfmt: drop nightly-gating of the `--style-edition` flag registration
    
    Follow-up to [Stabilize `style_edition = "2024"` in-tree #134929](#134929).
    
    #134929 un-nightly-gated the *read* of `--style-edition`, but didn't also un-nightly-gate the *registration*/*declaration* of the `--style-edition` flag itself. Reading `--style-edition` on a non-nightly channel (e.g. beta) will thus panic because `--style-edition` is never declared.
    
    This PR also un-nightly-gates the registration. Not sure how to write a regression test for this, because this *requires* the non-nightly / beta channel. Though existing tests do fail (albeit indirectly).
    
    Checking if this fixes the panic against beta in #135197.
    
    r? rustfmt
    matthiaskrgr authored Jan 7, 2025
    Configuration menu
    Copy the full SHA
    5dd21df View commit details
    Browse the repository at this point in the history
  8. Auto merge of #135218 - matthiaskrgr:rollup-xngklx8, r=matthiaskrgr

    Rollup of 6 pull requests
    
    Successful merges:
    
     - #133810 (remove unnecessary `eval_verify_bound`)
     - #134745 (Normalize each signature input/output in `typeck_with_fallback` with its own span)
     - #134989 (Lower Guard Patterns to HIR.)
     - #135149 (Use a post-monomorphization typing env when mangling components that come from impls)
     - #135171 (rustdoc: use stable paths as preferred canonical paths)
     - #135200 (rustfmt: drop nightly-gating of the `--style-edition` flag registration)
    
    r? `@ghost`
    `@rustbot` modify labels: rollup
    bors committed Jan 7, 2025
    Configuration menu
    Copy the full SHA
    0707499 View commit details
    Browse the repository at this point in the history
Loading