Skip to content

Commit ec1ef79

Browse files
committed
Updated the messages for E0017
- Fix note message, fix tests.
1 parent 4c02363 commit ec1ef79

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/librustc_mir/transform/qualify_consts.rs

+6-3
Original file line numberDiff line numberDiff line change
@@ -616,9 +616,12 @@ impl<'a, 'tcx> Visitor<'tcx> for Qualifier<'a, 'tcx, 'tcx> {
616616
if !allow {
617617
self.add(Qualif::NOT_CONST);
618618
if self.mode != Mode::Fn {
619-
span_err!(self.tcx.sess, self.span, E0017,
620-
"references in {}s may only refer \
621-
to immutable values", self.mode);
619+
struct_span_err!(self.tcx.sess, self.span, E0017,
620+
"references in {}s may only refer \
621+
to immutable values", self.mode)
622+
.span_label(self.span, &format!("{}s require immutable values",
623+
self.mode))
624+
.emit();
622625
}
623626
}
624627
} else {

src/test/compile-fail/E0017.rs

+6-1
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,16 @@ static X: i32 = 1;
1212
const C: i32 = 2;
1313

1414
const CR: &'static mut i32 = &mut C; //~ ERROR E0017
15+
//~| NOTE constants require immutable values
1516
//~| ERROR E0017
17+
//~| NOTE constants require immutable values
1618
static STATIC_REF: &'static mut i32 = &mut X; //~ ERROR E0017
19+
//~| NOTE statics require immutable values
1720
//~| ERROR E0017
21+
//~| NOTE statics require immutable values
1822
//~| ERROR E0388
1923
static CONST_REF: &'static mut i32 = &mut C; //~ ERROR E0017
24+
//~| NOTE statics require immutable values
2025
//~| ERROR E0017
21-
26+
//~| NOTE statics require immutable values
2227
fn main() {}

0 commit comments

Comments
 (0)