Temporarily downgrade `uninlined_format_args` (to `pedantic` or `nursery`)

[Rudxain]

Description

Since format_args_capture is still not supported by rust-analyzer, suggesting to inline vars is actually a bad idea, because it makes refactoring harder (devs must manually rename vars).

I suggest we move it to the restriction group while that issue is still open.

Version

No response

Additional Labels

No response

[kraktus]

It seems strange to degrade it for every clippy users, when it’s a RA-issue. The logic would be that they set up a workaround on their side.

[Rudxain]

The logic would be that they set up a workaround on their side

Fair enough. But it seems that may take a while, possibly months, perhaps 2 years at most

[xFrednet]

Macros are not the easiest when it comes to static analysis. Moving the lint to restriction is too much IMO, but we could maybe move to pedantic. This was a lint, where the correct lint level was hard to decide. There was a Zulip discussion about this: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60uninlined_format_args.60.20category/near/306306974

I think it'd make sense to keep the lint as pedantic until ra supports this feature better. I'll ask what the others think :)

[nyurik]

I would rather not change the group - the lint is already reduced from its maximum capacity (it doesn't inline the mixed cases unless there is a setting enabling it). I would love to help (time permitting) for it to be resolved on RA side .. maybe? Might be an interesting experiment

[nyurik]

Per zulip discussion, we decided not to do this.

[Rudxain]

Per zulip discussion, we decided not to do this.

Ok, I'll close the issue for now

[jeff-hiner]

The latest Rust update was incredibly disruptive to my team, as we had to go through 27 different crates in our workspace to turn this off. rust-analyzer can't introspect format strings and tokenize these variable names, which completely breaks our debug flow-- I can't ctrl-f for log line output, then ctrl-click the offending variable.

While this is arguably a shortcoming in rust-analyzer, that doesn't help those of us staying on stable to try to minimize disruptions to our build and debugging workflows. Please reconsider moving this to pedantic.

[Manishearth]

Hmm, the reason we originally decided against this was that:

• the lint had changed/improved since it was originally a problem
• some of the people initially involved had changed their minds

It's clearly enough of a problem for people still; we should revisit this.

In general Clippy's policy is that needing to put allows in your code is not a huge issue, but I think rust-analyzer is a big enough factor here that we should try to be consistent with it.

cc @xFrednet @nyurik @Alexendoo as people who were involved in that decision

[nyurik]

My understanding, which might be incorrect, is that while Rust-analyzer cannot handle inlined arguments yet, it is not directly related to clippy -- i.e. someone can still write code with inlined args, or fix existing code with cargo clippy --fix. Moreover, the rust-analyzer code itself has had all arguments inlined, so assuming the team is dogfooding their own code, it seem to work ok for them.

@jeff-hiner you said you had to change all your crates - did you essentially just add a #![allow(clippy::uninlined_format_args)] to each one? Is it because rust analyzer automatically applies clippy fixes, or some other issue?

One thing I obviously cannot measure is the "positive" vs "negative" - i.e. the number of those affected by this issue vs those who benefit from it, but are silent. Rust analyzer is a big player in the community, so we clearly should pay attention to it.

One other thing -- if we move it back to pedantic/restricted, I feel it would serve very limited purpose because by the time it rolls out to the users, 99% cases would have been fixed, so it won't have much affect. At the same time, having it on will encourage this issue to be fixed faster in all the relevant tools (I would love to help with that btw).