Skip to content

ui_test: require colon after command #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2022
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 8, 2022

Turns out we already use colons everywhere properly.

Also rename ui_test::comments to parser. I think that better describes its contents. :)

@oli-obk
Copy link
Contributor

oli-obk commented Jul 9, 2022

Ah oops. I know where we don't tho: with //~ style comments, after the ERROR part

@RalfJung
Copy link
Member Author

RalfJung commented Jul 9, 2022

Ah, I didn't even know we allow : there.
That would make the syntax without a level be //~:? That looks kind of odd...

Co-authored-by: Oli Scherer <[email protected]>
@RalfJung
Copy link
Member Author

RalfJung commented Jul 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 9, 2022

📌 Commit 2850db9 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 9, 2022

⌛ Testing commit 2850db9 with merge 6bdc5d6...

@bors
Copy link
Contributor

bors commented Jul 9, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 6bdc5d6 to master...

@bors bors merged commit 6bdc5d6 into rust-lang:master Jul 9, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 9, 2022

Yea, maybe we should forbid //~ ERROR: asdfg and just require a space for consistency?

@RalfJung RalfJung deleted the ui-test branch July 9, 2022 14:11
@RalfJung
Copy link
Member Author

RalfJung commented Jul 9, 2022

Or we have to require some kind of keyword for "match an arbitrary level please". That would be the more robust thing to do, it avoids a silent fallback.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 9, 2022

At that point we can require the proper level name and add another //@ command that can forcibly increase the threshold for levels that need annotations (instead of just picking the lowest one of any of the existing annotations like we do now).

@RalfJung
Copy link
Member Author

RalfJung commented Jul 9, 2022

Yeah that would work as well.

bors added a commit that referenced this pull request Jul 11, 2022
require level and colon in `//~` style comments

implements #2348 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants