-
Notifications
You must be signed in to change notification settings - Fork 390
ui_test: require colon after command #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah oops. I know where we don't tho: with |
Ah, I didn't even know we allow |
Co-authored-by: Oli Scherer <[email protected]>
@bors r+ |
☀️ Test successful - checks-actions |
Yea, maybe we should forbid |
Or we have to require some kind of keyword for "match an arbitrary level please". That would be the more robust thing to do, it avoids a silent fallback. |
At that point we can require the proper level name and add another |
Yeah that would work as well. |
require level and colon in `//~` style comments implements #2348 (comment)
Turns out we already use colons everywhere properly.
Also rename ui_test::comments to parser. I think that better describes its contents. :)