Hashes are assumed to be only usize

[cuviper]

h1 will fail on 32-bit targets if a hasher yields a u64 greater than u32::MAX:
https://github.com/Amanieu/hashbrown/blob/9068eb7a2268d879dc4453ac72238e8a992f1469/src/raw/mod.rs#L120-L126

The comment in h2 gives some insight to this, but that only applies to FxHash:
https://github.com/Amanieu/hashbrown/blob/9068eb7a2268d879dc4453ac72238e8a992f1469/src/raw/mod.rs#L131-L138

See also the failure in rust-lang/rust#58623 (comment)

[Amanieu]

Yes, this assert was mistakenly added as part of the clippy support, it should be removed.

[cuviper]

Are there any tests using alternate hashes? Even RandomState should trigger this.

[gnzlbg]

Replacing the assert with a comment explaining why the truncation is ok and adding a test that triggers this sounds good to me.

[gnzlbg]

Is there an issue open to add a test for this ? The merged PR does not add any.

Or was that added in https://github.com/Amanieu/hashbrown/pull/63 ?

[Amanieu]

Tests were added in #63.

[gnzlbg]

Awesome, thank you both for fixing this, and sorry that I broke it!