This repository was archived by the owner on May 28, 2025. It is now read-only.
File tree Expand file tree Collapse file tree 1 file changed +8
-6
lines changed
src/bootstrap/src/core/build_steps Expand file tree Collapse file tree 1 file changed +8
-6
lines changed Original file line number Diff line number Diff line change @@ -1845,19 +1845,21 @@ NOTE: if you're sure you want to do this, please open an issue as to why. In the
1845
1845
}
1846
1846
}
1847
1847
1848
+ // FIXME(136096): on macOS, we get linker warnings about duplicate `-lm` flags.
1849
+ // NOTE: `stage > 1` here because `test --stage 1 ui-fulldeps` is a hack that compiles
1850
+ // with stage 0, but links the tests against stage 1.
1851
+ // cfg(bootstrap) - remove only the `stage > 1` check, leave everything else.
1852
+ if suite == "ui-fulldeps" && compiler. stage > 1 && target. ends_with ( "darwin" ) {
1853
+ flags. push ( "-Alinker_messages" . into ( ) ) ;
1854
+ }
1855
+
1848
1856
let mut hostflags = flags. clone ( ) ;
1849
1857
hostflags. push ( format ! ( "-Lnative={}" , builder. test_helpers_out( compiler. host) . display( ) ) ) ;
1850
1858
hostflags. extend ( linker_flags ( builder, compiler. host , LldThreads :: No ) ) ;
1851
1859
1852
1860
let mut targetflags = flags;
1853
1861
targetflags. push ( format ! ( "-Lnative={}" , builder. test_helpers_out( target) . display( ) ) ) ;
1854
1862
1855
- // FIXME: on macOS, we get linker warnings about duplicate `-lm` flags. We should investigate why this happens.
1856
- if suite == "ui-fulldeps" && target. ends_with ( "darwin" ) {
1857
- hostflags. push ( "-Alinker_messages" . into ( ) ) ;
1858
- targetflags. push ( "-Alinker_messages" . into ( ) ) ;
1859
- }
1860
-
1861
1863
for flag in hostflags {
1862
1864
cmd. arg ( "--host-rustcflags" ) . arg ( flag) ;
1863
1865
}
You can’t perform that action at this time.
0 commit comments