[Fix #14306] Fix an error for Style/HashConversion

This PR fixes an error for `Style/HashConversion`
when using nested `Hash[]`.

Fixes #14306.

Author: koic

changelog/fix_an_error_for_style_hash_conversion.md

@@ -0,0 +1 @@
+* [#14306](https://github.com/rubocop/rubocop/issues/14306): Fix an error for `Style/HashConversion` when using nested `Hash[]`. ([@koic][])

lib/rubocop/cop/style/hash_conversion.rb

@@ -54,7 +54,7 @@ class HashConversion < Base
         def_node_matcher :hash_from_array?, '(send (const {nil? cbase} :Hash) :[] ...)'
 
         def on_send(node)
-          return unless hash_from_array?(node)
+          return if part_of_ignored_node?(node) || !hash_from_array?(node)
 
           # There are several cases:
           # If there is one argument:
@@ -68,6 +68,7 @@ def on_send(node)
 
         private
 
+        # rubocop:disable Metrics/MethodLength
         def single_argument(node)
           first_argument = node.first_argument
           if first_argument.hash_type?
@@ -82,8 +83,11 @@ def single_argument(node)
               replacement = "(#{replacement})" if requires_parens?(first_argument)
               corrector.replace(node, "#{replacement}.to_h")
             end
+
+            ignore_node(node)
           end
         end
+        # rubocop:enable Metrics/MethodLength
 
         def use_zip_method_without_argument?(first_argument)
           return false unless first_argument&.send_type?
@@ -111,7 +115,12 @@ def register_offense_for_zip_method(node, zip_method)
         end
 
         def requires_parens?(node)
-          (node.call_type? && node.arguments.any? && !node.parenthesized?) || node.operator_keyword?
+          if node.call_type?
+            return false if node.method?(:[])
+            return true if node.arguments.any? && !node.parenthesized?
+          end
+
+          node.operator_keyword?
         end
 
         def multi_argument(node)

spec/rubocop/cop/style/hash_conversion_spec.rb

@@ -175,6 +175,28 @@
     RUBY
   end
 
+  it 'reports an offense when using nested `Hash[]` without arguments' do
+    expect_offense(<<~RUBY)
+      Hash[Hash[]]
+      ^^^^^^^^^^^^ Prefer ary.to_h to Hash[ary].
+    RUBY
+
+    expect_correction(<<~RUBY)
+      Hash[].to_h
+    RUBY
+  end
+
+  it 'reports an offense when using nested `Hash[]` with arguments' do
+    expect_offense(<<~RUBY)
+      Hash[Hash[k, v]]
+      ^^^^^^^^^^^^^^^^ Prefer ary.to_h to Hash[ary].
+    RUBY
+
+    expect_correction(<<~RUBY)
+      Hash[k, v].to_h
+    RUBY
+  end
+
   context 'AllowSplatArgument: true' do
     let(:cop_config) { { 'AllowSplatArgument' => true } }