Skip to content

Fix relative links on https://rspec.info/features/6-0/rspec-rails/controller-specs/ #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

danieldiekmeier
Copy link
Contributor

While reading up on Controller Specs, I noticed that almost all the links on the page are broken.

For example, the render_template links to:

https://rspec.info/features/6-0/rspec-rails/controller-specs/matchers/render-template-matcher

but should link to

https://rspec.info/features/6-0/rspec-rails/matchers/render-template-matcher

I added the additional . to achieve this.

@pirj
Copy link
Member

pirj commented Sep 29, 2023

Thank you!

@JonRowe do we still use https://github.com/RSpec-Staging/rspec-staging.github.io for live previews? I don’t have merge rights there.

@JonRowe JonRowe merged commit 381c5b7 into rspec:source Sep 30, 2023
JonRowe added a commit that referenced this pull request Sep 30, 2023
@JonRowe
Copy link
Member

JonRowe commented Sep 30, 2023

Thanks, the process for building these docs is still a bit manual, need to also update the docs in the repo

@danieldiekmeier danieldiekmeier deleted the patch-1 branch September 30, 2023 15:57
@danieldiekmeier
Copy link
Contributor Author

Thank you for merging! I'll try to keep this in mind and update the HTML files myself the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants