Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-support
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.10.1
Choose a base ref
...
head repository: rspec/rspec-support
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.10.2
Choose a head ref
  • 14 commits
  • 19 files changed
  • 2 contributors

Commits on Jan 8, 2021

  1. Updated ci build scripts (from rspec-dev)3-10-maintenance

    @JonRowe
    JonRowe committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    6201782 View commit details
    Browse the repository at this point in the history

  2. Ignore extra JRuby line from 1.7

    @JonRowe
    JonRowe committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    a6c4270 View commit details
    Browse the repository at this point in the history

  3. Expand JRuby pending check to exclude 1.7

    @JonRowe
    JonRowe committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    c88e2c4 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #487 from rspec/update-ci-build-scripts-2021-01-08… 

    …-for-3-10-maintenance

Updates from rspec-dev (2021-01-08)
    @JonRowe
    JonRowe authored Jan 8, 2021
    Configuration menu
    Copy the full SHA
    8dd49af View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Fix simplecov source file filter 

    simplecov 0.20.0 does filtering with abosulute file paths.
We were not excluding `bundle` directory.

Before (https://github.com/rspec/rspec-support/runs/1627962469)
```
Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-support/coverage. 956 / 1444 LOC (66.2%) covered.

Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 3116 / 3596 LOC (86.65%) covered.
```

After
(https://github.com/rspec/rspec-support/pull/480/checks?check_run_id=1628102829)
```
Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-support/coverage. 519 / 544 LOC (95.4%) covered.

Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 2767 / 2797 LOC (98.93%) covered.
```

Debug output, excerpt from `coverage/index.html`
(https://github.com/rspec/rspec-expectations/pull/1273/checks?check_run_id=1628049675):

```
<td class="strong t-file__name">...bundle/ruby/2.7.0/gems/diff-lcs-1.4.4/lib/diff/lcs.rb">bundle/ruby/2.7.0/gems/diff-lcs-1.4.4/lib/diff/lcs.rb ...</td>
<td class="red strong cell--number t-file__coverage">33.08 %</td>
```
    @pirj @JonRowe
    pirj authored and JonRowe committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    d8604d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Backported pinned gems

    @JonRowe
    JonRowe committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    34968a4 View commit details
    Browse the repository at this point in the history

  2. Updated ci build scripts (from rspec-dev)3-10-maintenance

    @JonRowe
    JonRowe committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    34f6c85 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #489 from rspec/update-ci-build-scripts-2021-01-22… 

    …-for-3-10-maintenance

Updates from rspec-dev (2021-01-22)
    @JonRowe
    JonRowe authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    3c16c97 View commit details
    Browse the repository at this point in the history

  4. Updated ci build scripts (from rspec-dev)3-10-maintenance

    @JonRowe
    JonRowe committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    b9b3a63 View commit details
    Browse the repository at this point in the history

  5. Remove .travis.yml

    @JonRowe
    JonRowe committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    49296c8 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #491 from rspec/update-ci-build-scripts-2021-01-22… 

    …-for-3-10-maintenance

Updates from rspec-dev (2021-01-22)
    @JonRowe
    JonRowe authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    7741eca View commit details
    Browse the repository at this point in the history

  7. Update build status

    @JonRowe
    JonRowe authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    50a4555 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Merge pull request #492 from rspec/bugfix-for-jruby 

    Prevent JRuby build failure by sending to Kernel.require
    @JonRowe
    JonRowe committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    b39cedd View commit details
    Browse the repository at this point in the history

  2. v3.10.2

    @JonRowe
    JonRowe committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    76f13aa View commit details
    Browse the repository at this point in the history
Loading