stub_model & mock_model handle mock_with syntax = [:expect]. #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test for failure stubbing/mocking models when mock_with is set to `config.syntax = [:expect]` (no :should option) so #stub is unavailable.
When configured without the :should mode present, the #stub method is not available. RSpec::Rails::Mocks.add_stubs bypasses the switchable syntax layer, directly configuring a Matchers::Receive instance.
| @@ -96,7 +103,8 @@ def self.primary_key; :id; end | |||
| :valid? => true, | |||
| :blank? => false) | |||
|
|
|||
| double("#{model_class.name}_#{stubs[:id]}", stubs).tap do |m| | |||
| double("#{model_class.name}_#{stubs[:id]}").tap do |m| | |||
| RSpec::Rails::Mocks.add_stubs(m, stubs) | |||
| m.singleton_class.class_eval do | |||
There was a problem hiding this comment.
This change would not be necessary after double(name, stubs) is fixed in rspec/rspec-mocks#306, but it's a safe option for the moment.
|
Nice catch here, thank you. I definitely want this in before 2.14.0. Once I hear back from Myron on the interface, I'll get this merged. |
I'll be happy to. |
alindeman
added a commit
that referenced
this pull request
Jul 4, 2013
alindeman
added a commit
that referenced
this pull request
Jul 4, 2013
|
Nice, thanks for getting that done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configured without the
:shouldmode present, the#stubmethod isnot available. This means
stub_modelandmock_modelare broken in thisconfiguration.
Internal use of a new RSpec::Rails::Mocks.add_stubs method bypasses the
switchable syntax layer, directly configuring a Matchers::Receive instance.
Includes regression test for failure stubbing/mocking models when mock_with is
set to
config.syntax = [:expect](no :should option).See also: rspec/rspec-mocks#306