Skip to content

Enable yard and bump doc #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Conversation

benoittgt
Copy link
Member

Close: #1938

@benoittgt
Copy link
Member Author

Do we want to fix this CI? I have many failures on old ruby like https://travis-ci.org/rspec/rspec-rails/jobs/659827021

@pirj
Copy link
Member

pirj commented Mar 8, 2020

Will 3-9-maintenance build fail with no changes?

Do you plan to update yard on 3.9.x or 4.0.0beta branches?

@benoittgt
Copy link
Member Author

Will 3-9-maintenance build fail with no changes?

The last build also failed on 3-9-maintenance https://github.com/rspec/rspec-rails/commits/3-9-maintenance

Do you plan to update yard on 3.9.x or 4.0.0beta branches?

Yes. 3-9-maintenance, 4-0-maintenance, master.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's fix 3.9 builds separately from this.

Yard need Redcarpet upgraded otherwise it can find it
@benoittgt benoittgt force-pushed the enable-yard-and-bump-doc branch from d2f98c9 to f4daf68 Compare March 8, 2020 17:14
@benoittgt benoittgt merged commit c3beb81 into 3-9-maintenance Mar 8, 2020
@benoittgt benoittgt deleted the enable-yard-and-bump-doc branch March 8, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants