Change negated active job matcher, fixes #1870 #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When expecting no job to be enqueued, the matcher would expect exactly one job not to have been enqueued. This commit changes so that it now expects no jobs to have been enqueued.
|
Thanks! |
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
Jan 17, 2019
This is a partial backport of rspec#2069 that doesn't include changes on "have_enqueued_mail" tests. When expecting no job to be enqueued, the matcher would expect exactly one job not to have been enqueued. This commit changes so that it now expects no jobs to have been enqueued.
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
This is a partial backport of rspec#2069 that doesn't include changes on "have_enqueued_mail" tests. When expecting no job to be enqueued, the matcher would expect exactly one job not to have been enqueued. This commit changes so that it now expects no jobs to have been enqueued.
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
When expecting no job to be enqueued, the matcher would expect exactly one job not to have been enqueued. This commit changes so that it now expects no jobs to have been enqueued.
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
This was referenced Oct 10, 2019
This was referenced Oct 18, 2019
Closed
This was referenced Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change negated active job matcher, fixes #1870
When using the active job matchers, they will default to expecting a job to be enqueued exactly once. This results in some non intuitional behaviour, when using the negated matcher.
Consider the following example:
Some would read this as "When enqueuing two heavy lifting jobs I expect no jobs to have been enqueued". Since two jobs are actually enqueued it should fail, which it previously would not.
This pull request fixes this issue by setting the default expectation to use "at least once" when using the negated matcher.