Skip to content

Add support for ActiveJob argument matchers #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

antstorm
Copy link
Contributor

Hi,

This PR adds support for argument list matcher when matching ActiveJob arguments. Not only it is convenient, but also provides consistency with RSpec's method arguments matcher. Here's an example:

expect {
  hello_job.perform_later(42, "David")
}.to have_enqueued_job.with(instance_of(Fixnum), instance_of(String))

@fables-tales
Copy link
Member

LGTM

@fables-tales fables-tales merged commit 39d0f9e into rspec:master Oct 24, 2016
@antstorm antstorm deleted the support-for-argument-matchers branch October 24, 2016 13:31
@antstorm
Copy link
Contributor Author

@samphippen cheers mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants