removed rails 5.0 check for mailer spec generator #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this needs to be here as the recommended way to add a mailer in Rails 5 is |
|
@JonRowe Oh ok got it will change accordingly, Thank you. |
7ce37af to
c9c4841
Compare
|
@JonRowe Fixed. Please check it. |
JonRowe
requested changes
Oct 24, 2016
| @@ -1,10 +1,10 @@ | |||
| require "rails_helper" | |||
|
|
|||
| <% module_namespacing do -%> | |||
| RSpec.describe <%= class_name %><%= Rails.version.to_f >= 5.0 ? "Mailer" : "" %>, <%= type_metatag(:mailer) %> do | |||
| RSpec.describe <%= class_name.gsub(/Mailer$/i, '') %><%= Rails.version.to_f >= 5.0 ? "Mailer" : "" %>, <%= type_metatag(:mailer) %> do | |||
There was a problem hiding this comment.
I'd prefer it if we did this like this:
<%= Rails.version.to_f >= 5.0 ? class_name.gsub(/(Mailer)?$/i, 'Mailer') : class_name %>
As this will only run the modification on the edge case we know exists.
|
Thanks, I've suggested a slight improvement, see what you think :) |
c9c4841 to
fdcbb91
Compare
|
@JonRowe Modified. Please review. Thanks |
JonRowe
approved these changes
Oct 25, 2016
|
👍 😄 |
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary code in
lib/generators/rspec/mailer/templates/mailer_spec.rbNow if we give
rails g mailer CommentMailerit generates the correct files/classes with file
comment_mailer_spec.rbcontaining asdescribe
CommentMailerinstead ofCommentMailerMailerFixed: #1727