Adds documentation and feature for job specs #1725
Conversation
Updates existing documentation with a section on job specs and adds a related cucumber feature.
Job specs must be set up with the correct queue adapter, otherwise an exception will be thrown. Adding an additional step definition allows this scenario to be tested.
|
👋 @cupakromer @samphippen: Would you please review these changes. |
|
I really like this. I'd like to give a more thorough review tomorrow morning, but most likely we can just merge this in. Thank you so much @sgerrand |
|
@samphippen: I'm happy to wait, there's no rush on my end. 🙇 |
| @@ -321,6 +321,28 @@ end | |||
| For more information, see the [cucumber scenarios for mailer specs | |||
| ](https://relishapp.com/rspec/rspec-rails/v/3-4/docs/mailer-specs). | |||
|
|
|||
| ## Job specs | |||
|
|
|||
| Job specs default to residing in the `spec/jobs` folder. Tagging any context | |||
There was a problem hiding this comment.
Inferring spec location is deprecated so these sentences are the wrong way around, although it does line up with the rest of the file may I suggest:
Tagging a context with the metadata
:type => :jobtreats it's examples as job specs. Typically these specs will live inspec/jobs.
You've already mentioned the config option in the actual cuke (🙌) so I think this will suffice
There was a problem hiding this comment.
👍 So long as I use
its examples
Thanks for the speedy review. 💝
Applying [PR feedback](rspec#1725 (comment)).
|
Thanks @sgerrand :) |
| ``` | ||
|
|
||
| For more information, see the [cucumber scenarios for job specs | ||
| ](https://relishapp.com/rspec/rspec-rails/docs/job-specs). |
There was a problem hiding this comment.
If you'd like to fix this, I'd welcome a PR!, this ones already been merged tho.
There was a problem hiding this comment.
Yeah I wasn't clear if there was some kind of a deploy that needed to happen to make the URL work so it wasn't clear to me what the fix would be.
There was a problem hiding this comment.
Sorry, you're totally right, /cc @myronmarston how do we publish to relish again?
There was a problem hiding this comment.
Hmm, one flaw in this plan, I don't have access!
There was a problem hiding this comment.
I've signed up with the usual email address if you want to add me so I can do this Myron.
There was a problem hiding this comment.
I just added you as a collaborator.
There was a problem hiding this comment.
Link works now, thanks @myronmarston and @drewish
* Add documentation for ActiveJob specs Updates existing documentation with a section on job specs and adds a related cucumber feature. * Add failing example for configuration error Job specs must be set up with the correct queue adapter, otherwise an exception will be thrown. Adding an additional step definition allows this scenario to be tested. * Updates top level documentation for job specs Applying [PR feedback](#1725 (comment)).
|
💝 Thanks, @JonRowe.
|
* Add documentation for ActiveJob specs Updates existing documentation with a section on job specs and adds a related cucumber feature. * Add failing example for configuration error Job specs must be set up with the correct queue adapter, otherwise an exception will be thrown. Adding an additional step definition allows this scenario to be tested. * Updates top level documentation for job specs Applying [PR feedback](rspec#1725 (comment)).
💁 These changes update the existing documentation with a section on job specs, as well as adding a related cucumber feature.
Closes #1335