Skip to content

Update gem description to include Rails 5. #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2016

Conversation

benpickles
Copy link
Contributor

No description provided.

@fables-tales
Copy link
Member

@myronmarston @JonRowe how do you feel about bumping to 3.5.1 for this and release?

@myronmarston
Copy link
Member

I think it definitely makes sense to cherry-pick this to the 3-5-maintenance branch to be included in the next release, but it feels unnecessary to cut a release with just this. This doesn't affect any functionality, after all -- it's basically just a glorified comment.

@fables-tales
Copy link
Member

@myronmarston that seems good. I'll do that :)

@fables-tales
Copy link
Member

Closing in favour of #1654

@myronmarston
Copy link
Member

@samphippen this commit should be included in master and 3-5-maintenance, so why not merge this one to get it in master? Usually we just cherry-pick the commits to the maint branch instead of opening another PR (unless we are concerned about it causing a failing build in the branch).

@fables-tales
Copy link
Member

Ah right. Yes. Sorry, Misunderstood what you meant by cherry pick. I'll merge this one in now.

@fables-tales fables-tales reopened this Jul 4, 2016
@fables-tales fables-tales merged commit fc4f530 into rspec:master Jul 4, 2016
@fables-tales
Copy link
Member

@benpickles thanks for this! it's now merged into all the relevant RSpec branches :)

@benpickles
Copy link
Contributor Author

My pleasure.

Thanks for maintaining such a great library, it's nice to watch development in the open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants