Reorganise matchers #1635
Merged
Reorganise matchers #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2a3294 to
88938bb
Compare
|
/cc @samphippen be good to get this into the 3.5 release, it should make active job matchers (and more) available more widely |
|
LGTM. |
|
Bah, realised this is a semver violation, I'll rework it. |
|
@JonRowe isn't everything that you merged marked api privatE? |
|
Yes apart from |
|
@JonRowe Thank you for poking at this. Much appreciated man. |
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* segreate generally usable matchers from rails context specific matchers * include general matchers in all contexts when rspec-rails is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #1488 by bringing the general matchers into "always included" but not the few very specific rails matchers.