Back port pull request #1388 from rspec/fix-regression-mailer-preview-path #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the spec suite to expose issues with `ActionMailer` being configured incorrectly when previews are not available. This addresses several issues: - The incorrect configuration options are only exposed once `ActionMailer::Base` is loaded; this forces the class to load in the mailer initializer and at the end of our script - This adds specs specifically for the "development" environment which were missing before; it appeared that by not setting the environment it would default to "development" per the script, however, when the command shells out the `RAILS_ENV` is already set to "test" from rspec running. To be certain we cover the other possible edge cases we specifically add more tests for `ActionMailer` not being available, and for a custom configuration being set after `rspec-rails` is loaded. - Despite us asking Rails to turn off eager loading in our custom script, several files were still getting eager loaded; this explicitly clears the eager load paths to stop this - This fixes how the mailer script is shelled out in Ruby 1.8.7; now the environment variables are properly formatted and standard error is piped to standard out Exposes the regression issue in #1386
The `preview_path` feature of `ActionMailer` was added in Rails 4.1. Versions before that release are not able to handle that configuration. The regression issue occurred in part to the spec suite overlooking changes to the environment and how that affects the shelling out. Additionally, the previous changes noted that the configuration for a particular module always responds to a setting; even when it should not. However, while this logic was noted for `show_previews`, a few lines further down, that same logic was overlooked for `preview_path`. It appears the only available methods for detecting `ActionMailer`, and it's features, is tasting the top-level `config` in addition to checking the Rails version string.
cupakromer
added a commit
that referenced
this pull request
Jun 5, 2015
Back port pull request #1388 from rspec/fix-regression-mailer-preview-path
|
@myronmarston all merged and green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a sanity check on the rails versions.