Add missing require to RSpec generator root
#1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1301. This fixes an issue where Rail's autoload does not find it in some environments.
|
Note to self: backport this to the |
|
LGTM, although I wonder if this shows a problem in the way the generators are tested. Might be worth putting some effort into improving them? |
|
@myronmarston if I could reproduce it'd be happy too. However, it seems neither Jon nor I have been able to yet. |
|
Makes sense. Merge when green. |
|
BTW, are you planning to cut a 3.2.1 release with this after you backport it? If you need help with that, let me know. |
JonRowe
added a commit
that referenced
this pull request
Feb 10, 2015
Add missing `require` to RSpec generator root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1301.
This fixes an issue where Rail's autoload does not find it in some
environments.