Global before :all hooks with specified :type are not run with 2.14.0

[jarmo]

Specifying global before :all hooks for specified :type does not work with rspec-rails version 2.14.0.

Here's how to reproduce it:

1. generate an empty project

> rails -v
Rails 4.0.0

> rails new rspec-rails-broken
      create
      create  README.rdoc
      create  Rakefile
      create  config.ru
      ...

2. add rspec-rails into Gemfile:

# Gemfile

group :development, :test do
  gem 'rspec-rails', '2.14.0'
end

3. setup it:

> bundle install
> rails g rspec:install

4. add a before hook with specific type into spec_helper:

RSpec.configure do |config|
  config.before :all, type: :request do
    raise "should fail!"
  end
end

5. create a request spec:

# spec/requests/failing_spec.rb

require "spec_helper"

describe "always failing" do
  it "should fail" do
  end
end

6. execute the spec and hope for failure:

> bundle exec rake db:migrate spec
ruby -S rspec ./spec/requests/failing_spec.rb
.

Finished in 0.002 seconds
1 example, 0 failures

7. the spec did not fail! This is because that before :all got not executed. The same happens when using different type - controller for example for spec/controllers/*_spec.rb.

It will work as inspected if using before :each instead or if downgrading to 2.13.2

[JonRowe]

Trying to debug this, what happens if you put type: :request into your describe e.g.:

describe "always failing", type: :request do
  it "should fail" do
  end
end

[jarmo]

Forgot to mention, that when nesting with context, then it seems to work as expected:

# spec/requests/working_spec.rb

describe "working" do
  context "yup, working" do
    it "will fail, as expected because before all hook will raise" do
    end
  end
end

Also, when removing type: :request filter from that global hook and checking the type, then it is :request for all the example groups in requests directory as expected:

# spec_helper.rb

before :all do
  p self.class.metadata[:type]
end

[JonRowe]

Yeah but there could be an ordering issue between rspec-rails automagically categorising specs and when your config is loaded.

[jarmo]

It might be that the problem is in fact in one of the rspec-rails rspec* dependencies.

[JonRowe]

In case anyone else gets time to work on this before I do, the problem here seems to be that the metadata is not being set on the top level ExampleGroup only the child Examples and ExampleGroups causing before(:all) to not trigger for the top level group.