Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.2.1
Choose a base ref
...
head repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.2.2
Choose a head ref
  • 9 commits
  • 14 files changed
  • 4 contributors

Commits on May 26, 2015

  1. If a view example's description contains no path elements, then do no…

    …t attempt to load a helper based on the example description.
    tinynumbers authored and cupakromer committed May 26, 2015
    Configuration menu
    Copy the full SHA
    2fcdb4a View commit details
    Browse the repository at this point in the history
  2. Fix action mailer preview path setup.

    This removes the unnecessary warning about a preview path set to a
    location other than `/spec/mailers/preview`.
    
    This does not force `ActionMailer` to load when the Railtie runs by
    removing the `defined?` check. This is necessary because the
    `ActionMailer` class only loads it's settings once, after it is first
    loaded. If we load the class in our Railtie any custom settings declared
    in a config block in an initializer will be ignored.
    
    An improved spec suite for the different permutations of availability of
    action mailer previews is included as well.
    cupakromer committed May 26, 2015
    Configuration menu
    Copy the full SHA
    24578d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    39556da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    132b778 View commit details
    Browse the repository at this point in the history
  5. extract disable_testunit_autorun method

    orien authored and cupakromer committed May 26, 2015
    Configuration menu
    Copy the full SHA
    8911e07 View commit details
    Browse the repository at this point in the history
  6. Fix load order 🐛

    This fixes an "undefined method `fixture_path`" error caused in
    `RSpec::Core::Configuration`. The issue occurs when a spec is created
    before rspec-rails is loaded. The cause is rspec-core attempts to
    include the `RSpec::Rails::FixtureSupport` module into the existing spec
    as soon as we tell the configuration about it, but have not told the
    configuration about the new related options.
    
    This moves the including of the module until after we have told the
    configuration about the dependent options.
    
    This includes a spec which is named in a manner to attempt to ensure it
    is the first spec loaded by rspec-core; which loads spec files
    alphabetically. To ensure we test the issue the run script is updated to
    also run this spec file standalone.
    
    When discussing #1355 it was agreed that we need to
    consider removing this global inclusion of the fixture support. Instead
    favoring including it in the `RailsExampleGroup`. A deprecation comment
    has been included to remind us later.
    cupakromer committed May 26, 2015
    Configuration menu
    Copy the full SHA
    fb0244e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c2d4828 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1380 from rspec/backport-bug-fixes

    Backport bug fixes
    cupakromer committed May 26, 2015
    Configuration menu
    Copy the full SHA
    72ea6ff View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2015

  1. Release 3.2.2.

    myronmarston committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    4803a81 View commit details
    Browse the repository at this point in the history
Loading