-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.2.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.2.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 14 files changed
- 4 contributors
Commits on May 26, 2015
-
If a view example's description contains no path elements, then do no…
…t attempt to load a helper based on the example description.
Configuration menu - View commit details
-
Copy full SHA for 2fcdb4a - Browse repository at this point
Copy the full SHA 2fcdb4aView commit details -
Fix action mailer preview path setup.
This removes the unnecessary warning about a preview path set to a location other than `/spec/mailers/preview`. This does not force `ActionMailer` to load when the Railtie runs by removing the `defined?` check. This is necessary because the `ActionMailer` class only loads it's settings once, after it is first loaded. If we load the class in our Railtie any custom settings declared in a config block in an initializer will be ignored. An improved spec suite for the different permutations of availability of action mailer previews is included as well.
Configuration menu - View commit details
-
Copy full SHA for 24578d9 - Browse repository at this point
Copy the full SHA 24578d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39556da - Browse repository at this point
Copy the full SHA 39556daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 132b778 - Browse repository at this point
Copy the full SHA 132b778View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8911e07 - Browse repository at this point
Copy the full SHA 8911e07View commit details -
This fixes an "undefined method `fixture_path`" error caused in `RSpec::Core::Configuration`. The issue occurs when a spec is created before rspec-rails is loaded. The cause is rspec-core attempts to include the `RSpec::Rails::FixtureSupport` module into the existing spec as soon as we tell the configuration about it, but have not told the configuration about the new related options. This moves the including of the module until after we have told the configuration about the dependent options. This includes a spec which is named in a manner to attempt to ensure it is the first spec loaded by rspec-core; which loads spec files alphabetically. To ensure we test the issue the run script is updated to also run this spec file standalone. When discussing #1355 it was agreed that we need to consider removing this global inclusion of the fixture support. Instead favoring including it in the `RailsExampleGroup`. A deprecation comment has been included to remind us later.
Configuration menu - View commit details
-
Copy full SHA for fb0244e - Browse repository at this point
Copy the full SHA fb0244eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d4828 - Browse repository at this point
Copy the full SHA c2d4828View commit details -
Merge pull request #1380 from rspec/backport-bug-fixes
Backport bug fixes
Configuration menu - View commit details
-
Copy full SHA for 72ea6ff - Browse repository at this point
Copy the full SHA 72ea6ffView commit details
Commits on Jun 3, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 4803a81 - Browse repository at this point
Copy the full SHA 4803a81View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.2.1...v3.2.2