Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-expectations
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.8.1
Choose a base ref
...
head repository: rspec/rspec-expectations
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.8.2
Choose a head ref
  • 7 commits
  • 13 files changed
  • 3 contributors

Commits on Sep 18, 2018

  1. Only call to_hash when actual object does not respond to include?

    This fixes a regression introduced with commit a0c3958 that occurs
    when an object has both an `include?` and a `to_hash` method. The
    include matcher was delegating to the `include?` method on the Hash
    returned from a call to `to_hash` instead of first checking if the
    object implements `include?`.
    
    A manual test was conducted to make sure that this change does not
    regress PR #1069. An instance of ActiveSupport::HashWithIndifferentAccess
    was used in that test.
    jkowens committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    a8467cc View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Merge pull request #1073 from jkowens/3-8-maintenance

    Only call to_hash when actual object does not respond to include?
    JonRowe authored Sep 20, 2018
    Configuration menu
    Copy the full SHA
    33e107c View commit details
    Browse the repository at this point in the history
  2. Changelog for #1073

    JonRowe committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    e4f3bb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Merge pull request #1075 from rspec/update-travis-build-scripts-2018-…

    …09-19-for-master
    
    Updates from rspec-dev (2018-09-19)
    JonRowe committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    fd8ab32 View commit details
    Browse the repository at this point in the history
  2. Changelog for #1076

    JonRowe committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    03f430e View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1077 from rspec/update_ffi

    Prevent Github vulnerability warning
    JonRowe committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    aafb62f View commit details
    Browse the repository at this point in the history
  4. Bump version to 3.8.2

    JonRowe committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    1097d74 View commit details
    Browse the repository at this point in the history
Loading