This repository was archived by the owner on Nov 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 386
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rspec/rspec-expectations
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rspec/rspec-expectations
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 50 files changed
- 3 contributors
Commits on Jun 14, 2014
-
Most of this conversion was done with transpec, but I had to discard some of its changes by hand since we test some deprecated/disallowed things here.
Configuration menu - View commit details
-
Copy full SHA for 08d8459 - Browse repository at this point
Copy the full SHA 08d8459View commit details -
No need to have two example groups for PositiveExpectationHandler.
Configuration menu - View commit details
-
Copy full SHA for 3fc8069 - Browse repository at this point
Copy the full SHA 3fc8069View commit details
Commits on Jun 17, 2014
-
Fix regression in
contain_exactly
.The new implementation in 3.0.0 allowed this to pass: expect([1]).to contain_exactly() The problem was that the `actual_matches` hash was lazily initialized in an `expected.each_with_index` loop. This meant that if `expected` was empty, `actual_matches` would be made empty as well, causing the match logic to pass. Fixes #581.
Configuration menu - View commit details
-
Copy full SHA for b995e6f - Browse repository at this point
Copy the full SHA b995e6fView commit details
Commits on Jun 18, 2014
-
Add more helpful error message for
change
.When change was called with a single argument and no block, the message to be sent to the receiver defaulted to nil, causing an unclear failure message. Fixes #584.
Configuration menu - View commit details
-
Copy full SHA for 450cdd9 - Browse repository at this point
Copy the full SHA 450cdd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb63656 - Browse repository at this point
Copy the full SHA fb63656View commit details
Commits on Jun 20, 2014
-
Make
contain_exactly
work with out of order hashes.The reason that this was failing is that `contain_exactly` assumed that its `expected` value was a matcher. As such it was using === to compare the expected value with the actual value. This is completely correct for matchers. However, when a hash is passed the implementation of === will not match the actual value at all. Hash === won't invoke the RSpec matchers. This fix uses the lower performance values_match? which correctly matches when hashes are provided. Fixes #574.
Configuration menu - View commit details
-
Copy full SHA for 39665ca - Browse repository at this point
Copy the full SHA 39665caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40df5f0 - Browse repository at this point
Copy the full SHA 40df5f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f7fdab - Browse repository at this point
Copy the full SHA 6f7fdabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e5f7ba - Browse repository at this point
Copy the full SHA 2e5f7baView commit details -
Configuration menu - View commit details
-
Copy full SHA for f49990a - Browse repository at this point
Copy the full SHA f49990aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dda635f - Browse repository at this point
Copy the full SHA dda635fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91ded59 - Browse repository at this point
Copy the full SHA 91ded59View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.0.1...v3.0.2