Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-expectations
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.1
Choose a base ref
...
head repository: rspec/rspec-expectations
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.2
Choose a head ref
  • 12 commits
  • 50 files changed
  • 3 contributors

Commits on Jun 14, 2014

  1. Disable monkey patching.

    Most of this conversion was done with transpec, but I had to
    discard some of its changes by hand since we test some
    deprecated/disallowed things here.
    myronmarston committed Jun 14, 2014
    Configuration menu
    Copy the full SHA
    08d8459 View commit details
    Browse the repository at this point in the history
  2. Merge two example groups.

    No need to have two example groups for PositiveExpectationHandler.
    myronmarston committed Jun 14, 2014
    Configuration menu
    Copy the full SHA
    3fc8069 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2014

  1. Fix regression in contain_exactly.

    The new implementation in 3.0.0 allowed this to pass:
    
    expect([1]).to contain_exactly()
    
    The problem was that the `actual_matches` hash was lazily
    initialized in an `expected.each_with_index` loop. This
    meant that if `expected` was empty, `actual_matches` would
    be made empty as well, causing the match logic to pass.
    
    Fixes #581.
    myronmarston committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    b995e6f View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2014

  1. Add more helpful error message for change.

    When change was called with a single argument and no block, the
    message to be sent to the receiver defaulted to nil, causing an
    unclear failure message.
    
    Fixes #584.
    AgentAntelope authored and myronmarston committed Jun 18, 2014
    Configuration menu
    Copy the full SHA
    450cdd9 View commit details
    Browse the repository at this point in the history
  2. Changelog for #585.

    [ci skip]
    myronmarston committed Jun 18, 2014
    Configuration menu
    Copy the full SHA
    fb63656 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2014

  1. Make contain_exactly work with out of order hashes.

    The reason that this was failing is that `contain_exactly` assumed that
    its `expected` value was a matcher. As such it was using === to compare
    the expected value with the actual value. This is completely correct for
    matchers. However, when a hash is passed the implementation of === will
    not match the actual value at all. Hash === won't invoke the RSpec
    matchers.
    
    This fix uses the lower performance values_match? which correctly
    matches when hashes are provided.
    
    Fixes #574.
    Sam Phippen authored and myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    39665ca View commit details
    Browse the repository at this point in the history
  2. Changelog entry for #578

    Sam Phippen authored and myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    40df5f0 View commit details
    Browse the repository at this point in the history
  3. Benchmarks on contain_exactly

    Sam Phippen authored and myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    6f7fdab View commit details
    Browse the repository at this point in the history
  4. Add a spec for in order hashes for contain_exactly

    Sam Phippen authored and myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    2e5f7ba View commit details
    Browse the repository at this point in the history
  5. Implementation and spec cleanup for #578

    Sam Phippen authored and myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    f49990a View commit details
    Browse the repository at this point in the history
  6. Forwardport 2.99.1 release notes.

    [ci skip]
    myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    dda635f View commit details
    Browse the repository at this point in the history
  7. Release 3.0.2.

    [ci skip]
    myronmarston committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    91ded59 View commit details
    Browse the repository at this point in the history
Loading