Remove rspec-doc-template yard plugin + remove empty lines from HTML doc #245
Conversation
We do not want Google Analytics because we don't use it Also rdoc/erb generate a lot of extra empty line in every html. We clean all the html files before.
| @@ -26,7 +26,7 @@ def run_command(command, opts={}) | |||
| FileUtils.cd(path) do | |||
| puts "#{'='*3} #{dir} #{'='*(40 - dir.length)}" | |||
| begin | |||
| Bundler.clean_system(command) | |||
| Bundler.unbundled_system(command) | |||
There was a problem hiding this comment.
Hm theres a reason we were using clean_system but I've forgotten what it is
There was a problem hiding this comment.
In my case, I just followed the deprecation warning.
There was a problem hiding this comment.
Ah then I think its a bundler 1 vs 2 issue
There was a problem hiding this comment.
Is this a blocker for this PR?
On another project we added an helper method that check if unbundled_system was defined, if not, fallback to clean_system. But I think we can keep it like this.
I didn't try all the rake commands and I lack history on the subject so feel free to tell me Jon.
There was a problem hiding this comment.
No it's our dev tools, we can always revert.
The previous script run commands `ag` commands on rspec-github.io and not the source/lib/version folder. It means we are doing extra work everytime we generate documentation. With this change we reduce the scope of files that can be processed but also the command is much faster.
|
Sorry, last night I remember that my script to remove lines is not scoped to the rspec gem version you want in I added a commit that do This was maybe a choice that is wanted. I can revert it. 😊 I will keep the all lines already removed in rspec.gihub.io because it is a necessary cleaning. The last commit do not change the doc generated (expect doc generation timestamp in footer). |
|
Thanks Jon :) |
Related: