Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.0
Choose a base ref
...
head repository: rspec/rspec-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.4.1
Choose a head ref
  • 4 commits
  • 8 files changed
  • 1 contributor

Commits on Nov 12, 2015

  1. Configuration menu
    Copy the full SHA
    de8d283 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2015

  1. Make wording more accurate.

    The existing wording was confusing for this situation:
    
    * You have two specs, a and b.
    * Spec a always fails.
    * Spec b fails only if a runs first.
    
    In such a situation, your failures are order dependent,
    but our bisector printed "failure is not order dependent",
    which was quite confusing. The new wording,
    "failures(s) do not require any non-failures to run first"
    is more accurate.
    myronmarston committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    52b0b18 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2015

  1. Fix BacktraceFormatter to handle nil backtraces.

    `Exception.new.backtrace` is `nil` so we can't count on
    there always being a backtrace. Before now we relied
    on the `format_backtrace` caller handling this (passing
    `ex.backtrace || []`), but with #2074 now also including
    the `exception.cause` in failure output, the code there
    did not guard the `format_backtrace` call with `|| []`
    and is causing users to get a `NoMethodError`. It's
    easiest if `format_backtrace just handles the `nil` case
    so each caller does not have to remember to handle it.
    
    Fixes #2117.
    myronmarston committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    92c95d5 View commit details
    Browse the repository at this point in the history
  2. Release 3.4.1.

    myronmarston committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    7425a5c View commit details
    Browse the repository at this point in the history
Loading