This repository was archived by the owner on Nov 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 752
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rspec/rspec-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rspec/rspec-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 10 files changed
- 3 contributors
Commits on Sep 17, 2014
-
Merge pull request #1710 from rspec/fix-describe-nil-or-false
Fix `subject` for `describe nil` and `describe false`.
Configuration menu - View commit details
-
Copy full SHA for 1fb1e2c - Browse repository at this point
Copy the full SHA 1fb1e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29902b6 - Browse repository at this point
Copy the full SHA 29902b6View commit details
Commits on Sep 18, 2014
-
Allow users to filter subdirs of their current dir.
This also greatly simplifies the backtrace formatter; the system_exclusion_patterns approach made it more complicated, as did always having an inclusion_pattern. We only need the current directory as an inclusion_pattern when it matches one of the built-in exclusion patterns. Note that this was the approach that we originally had in #843; it got lost in the refactoring in #1062 (af0b271). While it seemed like a simpler approach to always put the current dir in the inclusion_patterns, in practice, this caused a sequence of whack-a-mole regressions: - #1328 (fixed by #1329) - #1604 (fixed by #1616) - #1705 (fixed by this commit) I'm hopeful that returning to only including the current dir in `inclusion_patterns` if it matches a built-in exclusion pattern will solve these issues once and for all.
Configuration menu - View commit details
-
Copy full SHA for 9f53daf - Browse repository at this point
Copy the full SHA 9f53dafView commit details -
Extract sandboxing logic into a separate file.
The formatting specs rely on a particular expected backtrace, which depends on which lines in particular bits of the sandboxing code are on. Before, changes to `spec_helper` would require updating the formatting support expected backtraces. This change will isolate it.
Configuration menu - View commit details
-
Copy full SHA for 9840240 - Browse repository at this point
Copy the full SHA 9840240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57e6962 - Browse repository at this point
Copy the full SHA 57e6962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a6504d - Browse repository at this point
Copy the full SHA 5a6504dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f11a2 - Browse repository at this point
Copy the full SHA c5f11a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b033750 - Browse repository at this point
Copy the full SHA b033750View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.1.3...v3.1.4