Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.3
Choose a base ref
...
head repository: rspec/rspec-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.4
Choose a head ref
  • 8 commits
  • 10 files changed
  • 3 contributors

Commits on Sep 17, 2014

  1. Merge pull request #1710 from rspec/fix-describe-nil-or-false

    Fix `subject` for `describe nil` and `describe false`.
    JonRowe committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    1fb1e2c View commit details
    Browse the repository at this point in the history
  2. changelog for #1710

    Conflicts:
    	Changelog.md
    JonRowe committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    29902b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2014

  1. Allow users to filter subdirs of their current dir.

    This also greatly simplifies the backtrace formatter;
    the system_exclusion_patterns approach made it more
    complicated, as did always having an inclusion_pattern.
    
    We only need the current directory as an inclusion_pattern
    when it matches one of the built-in exclusion patterns.
    
    Note that this was the approach that we originally had in #843;
    it got lost in the refactoring in #1062 (af0b271).
    While it seemed like a simpler approach to always put the current dir
    in the inclusion_patterns, in practice, this caused a sequence
    of whack-a-mole regressions:
    
    - #1328 (fixed by #1329)
    - #1604 (fixed by #1616)
    - #1705 (fixed by this commit)
    
    I'm hopeful that returning to only including the current dir
    in `inclusion_patterns` if it matches a built-in exclusion pattern
    will solve these issues once and for all.
    myronmarston committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    9f53daf View commit details
    Browse the repository at this point in the history
  2. Extract sandboxing logic into a separate file.

    The formatting specs rely on a particular expected
    backtrace, which depends on which lines in particular
    bits of the sandboxing code are on. Before, changes
    to `spec_helper` would require updating the formatting
    support expected backtraces. This change will isolate it.
    myronmarston committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    9840240 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57e6962 View commit details
    Browse the repository at this point in the history
  4. Reword changelog for #1710 for greater clarity.

    [ci skip]
    myronmarston committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    5a6504d View commit details
    Browse the repository at this point in the history
  5. Add changelog for #1708.

    myronmarston committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    c5f11a2 View commit details
    Browse the repository at this point in the history
  6. 3.1.4 release.

    myronmarston committed Sep 18, 2014
    Configuration menu
    Copy the full SHA
    b033750 View commit details
    Browse the repository at this point in the history
Loading