Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go.mod file #35

Merged
merged 2 commits into from
May 23, 2018
Merged

add go.mod file #35

merged 2 commits into from
May 23, 2018

Conversation

komuw
Copy link
Contributor

@komuw komuw commented May 23, 2018

add a go.mod file so as to prepare for vgo; https://github.com/golang/vgo

But the main reason I added this PR is so as to ask the maintainer to properly semver tag this repository.
right now github.com/rs/xid has git tags likev1.0 v1.1
If you have github.com/rs/xid as a dependency on your app and you use vgo as dependency manager; it is generating a go.mod file like;

module github/komuw/myModule

require (
	github.com/rs/xid v0.0.0-20170604230408-02dd45c33376
	github.com/rs/zerolog v1.4.0
)

instead of picking xid tag v1.1

So my proposal is that, this project should add a new semver tag like; v1.1.0

@rs rs merged commit 588ba10 into rs:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants