public method to check cors domain #115

alicebob · 2021-06-07T16:56:52Z

Fixes #114.
Exposes the isOriginAllowed() function so it can be used in gorilla/websocket, this way:

    return &websocket.Upgrader{
        ReadBufferSize:  1024,
        WriteBufferSize: 1024,
        CheckOrigin:     c.OriginAllowed,
    }

alicebob · 2021-06-07T16:57:40Z

cors.go

+// check the Origin of a request. No origin at all is also allowed.
+func (c *Cors) OriginAllowed(r *http.Request) bool {
+	origin := r.Header.Get("Origin")
+	if origin == "" {


You may or may not want this default.

Why don't you let the isOriginAllowed decide?

Good question :)
Removed.

alicebob added 2 commits June 7, 2021 16:38

add go.sum

2b7cb6b

expose isOriginAllowed() as OriginAllowed()

d0724ca

alicebob commented Jun 7, 2021

View reviewed changes

remove default

d9eb006

rs merged commit 64821dd into rs:master Jun 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

public method to check cors domain #115

public method to check cors domain #115

alicebob commented Jun 7, 2021

alicebob Jun 7, 2021

rs Jun 7, 2021

alicebob Jun 7, 2021

public method to check cors domain #115

public method to check cors domain #115

Conversation

alicebob commented Jun 7, 2021

alicebob Jun 7, 2021

Choose a reason for hiding this comment

rs Jun 7, 2021

Choose a reason for hiding this comment

alicebob Jun 7, 2021

Choose a reason for hiding this comment