-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configs: ELN fixups #649
configs: ELN fixups #649
Conversation
enabled=1 | ||
repo_gpgcheck=0 | ||
type=rpm | ||
gpgcheck=1 | ||
gpgkey=file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-rawhide-primary | ||
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-eln-$basearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must be sure that this file exists on user machine (be it Fedora, Suse, CentOS). Please add the key to https://github.com/xsuchy/distribution-gpg-keys/ and then use the key from /usr/share/distribution-gpg-keys/* directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the keys to https://github.com/xsuchy/distribution-gpg-keys/tree/master/keys/fedora-eln and I will do a release this evening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xsuchy Thanks. I'll submit an update to this PR after that release has been done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xsuchy FYI, the Fedora ELN keys are (and should continue to be) the same as the current Fedora Rawhide keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmathesius Hmm then why the change? What is wrong on gpgkey=file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-rawhide-primary
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xsuchy Two reasons. The first is that RPM-GPG-KEY-fedora-rawhide-primary
was pointing to the F33 key until your commit a few minutes ago! The second is that I just slurped in the contents of the Fedora ELN repo configuration from https://src.fedoraproject.org/rpms/fedora-repos/blob/master/f/fedora-eln.repo which points to the revised location.
Now that rawhide points to F34, I can revert gpgkey
to be what you suggested above. Is that what you'd prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed an update setting gpgkey
to point to the Rawhide primary key. I tested by manually updated the /usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-rawhide-primary
symlink on my workstation to point to RPM-GPG-KEY-fedora-34-primary
and all is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that what you'd prefer?
Yes, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- align repo configuration with fedora-repos-eln by switching to BaseOS and AppStream instead of Everything - use explicit list of buildroot packages to install rather than comps group - drop support for ARM Signed-off-by: Merlin Mathesius <[email protected]>
@xsuchy Are there any other changes/improvements you'd like to see with this? Thanks! |
LGTM, but I will let @praiskup to merge this once he returns from PTO on Monday. |
It is interesting to see that ELN can live just with the appstream and baseos (no need for "optional" or "build-time-only" repo). |
Thank you for the PR! |
I've updated to this configuration with mock-2.6-1.fc33 and mock-core-configs-33-1.fc33. (With the previous configuration I got a problem with the missing buildsys-build group.) I run:
And I get:
|
I only see:
@mmathesius is this going to be fixed soon? |
It's a problem that appeared with the ELN compose. |
The missing |
|
AppStream instead of Everything