Skip to content

[jazzy] Allow unknown types in bag rewrite (backport #1812) #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 23, 2024

This PR will allow ros2 bag convert to process bag files with "unknown" message types.
Unknown are the types which typesupport is not available during the bag conversion operation.

Also added proper handling for the ament_index_cpp::PackageNotFoundError exception throwing from the ament_index_cpp::get_package_share_directory(package);. It was causing abnormal converter or recorder termination if the package for message definition was not found in ament_index.

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit cd7bd63)
@mergify mergify bot requested a review from a team as a code owner September 23, 2024 16:02
@mergify mergify bot requested review from MichaelOrlov and jhdcs and removed request for a team September 23, 2024 16:02
@MichaelOrlov MichaelOrlov changed the title Allow unknown types in bag rewrite (backport #1812) [jazzy] Allow unknown types in bag rewrite (backport #1812) Sep 23, 2024
@MichaelOrlov
Copy link
Contributor

Pulls: #1817
Gist: https://gist.githubusercontent.com/MichaelOrlov/ace05c3f65eddcf20c30cda9e7a62878/raw/8e7d4c193090d4bfa4ea9efb9a5b08777445b438/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp
TEST args: --packages-above rosbag2_cpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14597

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 61dd32f into jazzy Sep 23, 2024
12 checks passed
@MichaelOrlov MichaelOrlov deleted the mergify/bp/jazzy/pr-1812 branch September 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants