[iron] Propagate "custom_data" and "ros_distro" in to the metadata.yaml file during re-indexing (backport #1700) #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during re-indexing (#1700) * propagate custom data and ros_distro during reindexing Signed-off-by: Cole Tucker Signed-off-by: coalman321 <[email protected]> * fix ament uncrustify issue Signed-off-by: coalman321 <[email protected]> * only update metadata if size is nonzero Signed-off-by: coalman321 <[email protected]> * fix uncrustify issue and switch to empty Signed-off-by: coalman321 <[email protected]> * update reindexer test to verify custom data and ros_distro changes Signed-off-by: coalman321 <[email protected]> * Convert to use exact clock type for windows CI Signed-off-by: coalman321 <[email protected]> --------- Signed-off-by: coalman321 <[email protected]> (cherry picked from commit 804432c)
|
The original PR could be only partially backported since we don't have |
Signed-off-by: Michael Orlov <[email protected]>
|
Update:
|
- Rationale: Mcap storage doesn't store serialized metadata in bag directly on Iron and Humble. Backporting of the relevant #1423 is not possible without updating mcap vendor package to the v1.1.0 because we have dependencies from the mcap_reader_->metadataIndexes(); API which became available only in the foxglove/mcap#902 Signed-off-by: Michael Orlov <[email protected]>
9c73c2b to
0c0b038
Compare
MichaelOrlov
approved these changes
Jun 13, 2024
|
Pulls: #1711
|
|
The previous CI failure on Windows was due to the infrastracture issue. Wasn't able to download QT dependencies for build.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates the
custom_dataandros_distrofields from the underlying storage into themetadata.yamlfile during re-indexing.metadata.yamlwere left as default.custom_dataandros_distrometadata from the newest storage file contained within the log as custom data can be modified in the storage API between successive split files.This fixes #1699
This is an automatic backport of pull request #1700 done by Mergify.