Add python binding to close the SequentialWriter #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
|
@ros-pull-request-builder retest this please |
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/58901fb4df9691add3c91d1a433def9d/raw/6e1f8accecd041b5e6286d37ac871f7eb711a651/ros2.repos
|
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
Signed-off-by: Yadunund <[email protected]> (cherry picked from commit 422e754)
clalancette
pushed a commit
that referenced
this pull request
May 18, 2023
Signed-off-by: Yadunund <[email protected]> (cherry picked from commit 422e754) Co-authored-by: Yadu <[email protected]>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-05-18/31587/1 |
MichaelOrlov
pushed a commit
that referenced
this pull request
Dec 10, 2024
… and #1339) (#1829) * Add python binding to close the SequentialWriter Signed-off-by: Jannik Jose <[email protected]> * Expose more Writer methods in python interface (#1220) Signed-off-by: Emerson Knapp <[email protected]> --------- Signed-off-by: Jannik Jose <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to fix ros-visualization/rqt_bag#127