[iron] Add recorder stop() API (backport #1300)

[mergify]

This is an automatic backport of pull request #1300 done by Mergify.

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[MichaelOrlov]

Gist: https://gist.githubusercontent.com/MichaelOrlov/ec3532e44fbd21961822e268e61c5694/raw/b6678a24315515c1ea0a339873910a8168920912/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_cpp
TEST args: --packages-above rosbag2_transport rosbag2_cpp
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12071

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

@clalancette I want to merge this PR to the iron branch.
This PR exposing rosbag2_cpp::writer::close() and rosbag2_transport::close() API.
This is breaking API/ABI changes. Nevertheless, I would like to merge it to iron if you wouldn't mind since this PR will be must have to be able to fix multiple issues related to the signals handling on Windows without breaking API/ABI in future.
It is relates to the #1326 and #1270

[clalancette]

This is breaking API/ABI changes. Nevertheless, I would like to merge it to iron if you wouldn't mind since this PR will be must have to be able to fix multiple issues related to the signals handling on Windows without breaking API/ABI in future.

That's fine, we still have about 2 days to get these kind of changes in.

[MichaelOrlov]

@clalancette The same question here. Do you have any idea why so many test failures in ipr job https://build.ros2.org/job/Ipr__rosbag2__ubuntu_jammy_amd64/3/#showFailuresLink
While CI is green?

[MichaelOrlov]

@ros-pull-request-builder retest this please

[MichaelOrlov]

@clalancette It seems it was some intermittent problem in CI infrastructure. After retesting ipr job all tests are passing.

I am re-running the Windows CI job since it failed in some unrelated tests.

• Windows

Error message from previous CI run on Windows for reference.

FAIL: launch_testing_examples.check_node_launch_test.TestFixture.test_node_start
---------------------------------------------------------------------------------------------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\ci\ws\src\ros2\examples\launch_testing\launch_testing_examples\launch_testing_examples\check_node_launch_test.py", line 48, in test_node_start
    rclpy.init()
  File "C:\ci\ws\install\Lib\site-packages\rclpy\__init__.py", line 89, in init
    return context.init(args, domain_id=domain_id)
  File "C:\ci\ws\install\Lib\site-packages\rclpy\context.py", line 70, in init
    raise RuntimeError('Context.init() must only be called once')
RuntimeError: Context.init() must only be called once