Fix time.py and clock.py circular import #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type hints where I touched code Signed-off-by: Shane Loretz <[email protected]>
j-rivero
reviewed
Dec 9, 2021
| self, *, | ||
| seconds=0, nanoseconds=0, | ||
| clock_type: _rclpy.ClockType = _rclpy.ClockType.SYSTEM_TIME): | ||
| if not isinstance(clock_type, _rclpy.ClockType): |
There was a problem hiding this comment.
With the type annotation in the parameter, would be this redundant now?
There was a problem hiding this comment.
I debated that. The type annotation allows using a tool like mypy to statically check types. Python doesn't do runtime type checking, so the type annotation is not redundant with this explicit check, but does rclpy really need runtime type checking? I decided to not make a decision on that right now and left the code as is.
There was a problem hiding this comment.
thanks for the details, sounds totally reasonable to me.
j-rivero
approved these changes
Dec 9, 2021
|
CI (build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #858
This fixes a circular import between
time.pyandclock.py. Both need theClockTypetype, which comes from_rclpy_pybind11, buttime.pywas importing it fromclock.py. That forcedclock.pyto importTimeinside functions that used it.I also added type annotations where I touched code.