Add types to rcutils_logger.py

[InvincibleRMC]

No description provided.

[fujitatomoya]

lgtm with green CI

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

CI:

* Linux [![Build Status](https://camo.githubusercontent.com/8c169b4e9000ad061b716f61e60ddec43cb67dd841e877e30a76c46c1024d952/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f6c696e7578266275696c643d3231353835)](http://ci.ros2.org/job/ci_linux/21585/)

* Linux-aarch64 [![Build Status](https://camo.githubusercontent.com/7756bdd3d5acc9a83293429dcd85cfeadff5347020903d99af6a1b808d0a3d9e/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f6c696e75782d61617263683634266275696c643d3135383734)](http://ci.ros2.org/job/ci_linux-aarch64/15874/)

* Linux-rhel [![Build Status](https://camo.githubusercontent.com/0899416802b71cd8a97853c6c5212afb37a72aa7e933f0d37235d6955785bc47/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f6c696e75782d7268656c266275696c643d31303834)](http://ci.ros2.org/job/ci_linux-rhel/1084/)

* Windows [![Build Status](https://camo.githubusercontent.com/1e63ec047c780685355f9fc8855bcf3c2512bdaae3cc3cb0be1f6baee9f2d646/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f77696e646f7773266275696c643d3232333035)](http://ci.ros2.org/job/ci_windows/22305/)

Fixed RHEL failing

[InvincibleRMC]

@fujitatomoya Can you re-run the CI? It should be fixed now.

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

@fujitatomoya the Windows failure should be fixed.

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

@fujitatomoya Should Windows still be building?

[sloretz]

Pulls: #1249
Gist: https://gist.githubusercontent.com/sloretz/9b513f6f620dde4280acfd272da86108/raw/a1ba744672f1839cfb10e716abe6627626997d69/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14361

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[MichaelOrlov]

@sloretz @clalancette This PR caused regression in multiple tests in rosbag2 with the error message:

2024-08-06T09:14:51.2768272Z 4:     if sys.version_info >= (3, 12):
2024-08-06T09:14:51.2772576Z 4:         from typing import Unpack
2024-08-06T09:14:51.2773242Z 4:     else:
2024-08-06T09:14:51.2773636Z 4:         with suppress(ModuleNotFoundError):
2024-08-06T09:14:51.2774252Z 4: >           from typing_extensions import Unpack
2024-08-06T09:14:51.2775655Z 4: E           ImportError: cannot import name 'Unpack' from 'typing_extensions' (/usr/lib/python3/dist-packages/typing_extensions.py)
2024-08-06T09:14:51.2776690Z 4: 
2024-08-06T09:14:51.2777501Z 4: ../../install/rclpy/lib/python3.10/site-packages/rclpy/impl/rcutils_logger.py:41: ImportError

You can see a full log from one of the failing jobs

Curious if we can revert this PR?

[clalancette]

So we aren't seeing this failing in e.g. https://ci.ros2.org/view/nightly/job/nightly_linux_release/3164/ . My best guess is that the action there is using Ubuntu 22.04, instead of Ubuntu 24.04. Since we are only targeting Ubuntu 24.04, that action should probably be updated.

[sloretz]

My best guess is that the action there is using Ubuntu 22.04, instead of Ubuntu 24.04. Since we are only targeting Ubuntu 24.04, that action should probably be updated.

Looks like the action is indeed running 22.04

Operating System
Ubuntu
22.04.4
LTS

[MichaelOrlov]

Ok. Got it.

• I am currently trying to move forward with the long-lasting Update CI scripts to use Ubuntu Noble distros and bump action scripts to latest versions rosbag2#1709. However, still have compilation issues on the rosbag2 side, which need to be addressed

[drewhoener]

Is there a reason this can't be backported to jazzy? it would be nice to have the typedefs

[clalancette]

Is there a reason this can't be backported to jazzy? it would be nice to have the typedefs

We've had a bunch of back and forth on these various PRs to get them in. Also, we've had ongoing CI issues with these changes (and while this is not the direct fault of these PRs, it is exacerbating the problem). Thus, I'm not comfortable backporting these, at least until we figure out what the CI issues are and what the rest of the PRs look like.