Revert "Raise user handler exception in MultiThreadedExecutor. (#984)" (backport #1017) #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1017) This reverts commit 6c0847a. Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit e18084f)
fujitatomoya
approved these changes
Oct 6, 2022
|
CI:
|
|
CI:
|
|
I am not sure why windows does not start CI, retry again.
|
|
|
The one warning on Windows is unrelated to this, so merging. |
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
)" (ros2#1017) (ros2#1023) This reverts commit 6c0847a. Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit e18084f) Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Chen Lihui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1017 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com