Skip to content

increase the timeout for window platform to avoid flaky test #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

iuhilnehc-ynos
Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos commented Feb 27, 2023

A flaky test about launch_testing_examples\check_multiple_nodes_launch_test.py is always reported while running CI.

After comparing the success and failure cases between https://ci.ros2.org/job/ci_windows/18721/consoleFull and https://ci.ros2.org/job/ci_windows/18738/consoleFull, I suspect that the timeout of waiting on the Window platform might not be enough.

Successful log in https://ci.ros2.org/job/ci_windows/18721/consoleFull,

01:22:55 launch_testing_examples\check_multiple_nodes_launch_test.py RR.          [ 22%]

Failure log in https://ci.ros2.org/job/ci_windows/18738/consoleFull.

23:58:21 launch_testing_examples\check_multiple_nodes_launch_test.py RRF          [ 22%]

We can find two re-test actions even in the successful log. (RR.)

@iuhilnehc-ynos
Copy link
Contributor Author

First time to run CI on Window. (1/10)

  • Windows Build Status

@iuhilnehc-ynos
Copy link
Contributor Author

iuhilnehc-ynos commented Feb 27, 2023

ran CI with wrong value --package-select for CI_TEST_ARGS before, which should be --packages-select.
rerun CI (2/10),

  • Windows Build Status
22:29:56 launch_testing_examples\check_multiple_nodes_launch_test.py .            [ 22%]
no more `re-test` action

rerun CI (3/10),

  • Windows Build Status

rerun CI (4/10),

  • Windows Build Status

rerun CI (5/10),

  • Windows Build Status

rerun CI (6/10),

  • Windows Build Status

In order to not occupy the CI resource, I'll rerun a full CI later.

@iuhilnehc-ynos
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

I'm going to go ahead and merge this one, since it is low-risk and seems to be helping. We can always do another follow-up if this isn't enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants