Skip to content

Increase the WaitForNode timeout. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

clalancette
Copy link
Contributor

1 second is far too short, particularly on Windows. This may reduce the flakiness in this test.

Signed-off-by: Chris Lalancette [email protected]

This may fix (or at least improve) #340 . @Crola1702 FYI

1 second is far too short, particularly on Windows.  This
may reduce the flakiness in this test.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link

@Crola1702 Crola1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We will keep track of this test in windows builds.

@clalancette clalancette merged commit b70e515 into rolling Oct 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/increase-wait-for-node-timeout branch October 26, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants