deprecate non-namespaced xacro tags #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New cli option `--xacro-ns` allows to enforce the new policy requiring the xacro namespace prefix (and suppressing deprecation warnings). However, non-prefixed tags will not be modified by xacro anymore (as requested by ros#41, ros#59, ros#60). Partially reverted cb73cfd, handling <arg> tags in the same fashion as other tags, i.e. issue a warning if used without prefix and ignoring it with cli argument `--xacro-ns`.
codebot
added a commit
that referenced
this pull request
May 29, 2015
deprecate non-namespaced xacro tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to deprecate non-namespaced xacro tags, resolving #41, #59, #60 and the like.
The proposal is to issue a warning message, when xacro tags are used without the prefix.
Together with the warning, an appropriate shell command will be suggested to fix the tags.
People, who have already fixed their xacro files can use the new cli option
--xacro-nsto skip the deprecation tests and keep non-prefixed tags as they are.I partially reverted #60, handling the tag as all other tags, i.e. issue the deprecation message when used without prefix. The behaviour requested by #60 can be achieved using cli option
--xacro-ns.#60 silently broke existing xacro's that don't use the prefix... Now they get the deprecation warning.
What about macro usage: Currently, I don't require the xacro prefix for macro instantiation. IMHO this is reasonable, because the users can name their macros as they like and thus avoid name conflicts.