Skip to content

Use underscores instead of dashes in setup.cfg #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Use underscores instead of dashes in setup.cfg #254

merged 2 commits into from
Jul 14, 2021

Conversation

aprotyas
Copy link

New python3-setuptools warns about this.

Signed-off-by: Abrar Rahman Protyasha [email protected]

New `python3-setuptools` warns about this.

Signed-off-by: Abrar Rahman Protyasha <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are in here, can you add the [develop] section that every other setup.cfg script in our tree has (e.g. https://github.com/ros-visualization/rqt_top/blob/crystal-devel/setup.cfg)? That will just make it consistent. Thanks!

@aprotyas
Copy link
Author

aprotyas commented Jul 13, 2021

While we are in here, can you add the [develop] section that every other setup.cfg script in our tree has (e.g. https://github.com/ros-visualization/rqt_top/blob/crystal-devel/setup.cfg)? That will just make it consistent. Thanks!

Done in 6003fa1. I'm not sure about the CI failure though.


On a semi-related note, @clalancette is there a tracker for this Humble project item? script-dir and install-scripts will not be supported in future versions
I was looking at whether other packages need the same treatment as this PR. Results from today's source checkout (including the changes in this PR):

[09:31 abrar@open-robotics: ~]$ egrep -r --include=setup.cfg '(script-dir|install-scripts)' ~/ros2_rolling/src
[09:31 abrar@open-robotics: ~]$ 

@clalancette
Copy link
Contributor

We can ignore the CI failure on Dashing; that is vestigial and should go away soon.

@clalancette
Copy link
Contributor

On a semi-related note, @clalancette is there a tracker for this Humble project item? script-dir and install-scripts will not be supported in future versions

No, not exactly. We've just been fixing them as we see them. I think we've now gotten all of them :).

@aprotyas
Copy link
Author

aprotyas commented Jul 13, 2021

CI: (build: --packages-above-and-dependencies rqt_gui_py test: --packages-above rqt_gui_py)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

I'm going to go ahead and merge this. Thanks @aprotyas !

@clalancette clalancette merged commit c5f2d80 into ros-visualization:crystal-devel Jul 14, 2021
@aprotyas aprotyas deleted the aprotyas/fix-setup-cfg branch July 14, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants