Noetic networkhub #127
Noetic networkhub #127
Conversation
| @@ -23,6 +23,12 @@ | |||
|
|
|||
| # optional param is_hub_port_device, used if connected to a VINT hub | |||
| <!-- <param name="is_hub_port_device" value="false"/> --> | |||
|
|
|||
| # optional param server_name, required to locate remote network servers | |||
| <!-- <param name="server_name" value="myPhidgetServer" /> --> | |||
There was a problem hiding this comment.
There's some extra whitespace at the beginning of this line.
|
Thanks the PR, and for copy-pasting it everywhere. @clalancette : We should really think about whether we want to create a superclass where we can put all of this stuff so we don't duplicate code everywhere... |
That seems reasonable to me, though I likely won't have time to do it in the near future. I'll suggest we go ahead with this PR as-is (with whatever changes it needs), and then we can do a separate PR just doing that cleanup. |
Yes, I was going to suggest that as well. |
|
I've fixed the small whitespace error and merged the PR in 6734150. Thanks for your contribution! |
|
Thanks! Hurray for my first PR. My two cents is that the specifics for hardware diversification have to happen on some level, so it's kind of nice having these settings in all the repos individually? Then in a bigger launch file different phidgets can be all set with one argument |
|
It was your first PR? Nice! :) |
|
Thanks! And actually, I've just discovered setting the server parameters isn't necessary if one uses network discovery: PhidgetNet_enableServerDiscovery(PHIDGETSERVER_DEVICEREMOTE); would there be any reason to not have this enabled? I can add it as another launch parameter option, or we could just bake it in? |
|
I'd prefer it as a parameter. |
Added two parameters, server_name and server_ip, to allow connection to network & wireless VINT hubs to all libraries. Tested only on a temperature phidget, but should work on anything that connects to a vint hub. Closes ros-drivers#127.
This is a port of ros-drivers#127 to ROS2. Closes ros-drivers#135.
Added two parameters, server_name and server_ip, to allow connection to network & wireless VINT hubs to all libraries. Tested only on a temperature phidget, but should work on anything that connects to a vint hub.