Skip to content

Update travis config and rosinstall for noetic #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2020
Merged

Update travis config and rosinstall for noetic #439

merged 5 commits into from
Apr 22, 2020

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Apr 14, 2020

No description provided.

@matthew-reynolds
Migrate to new industrial_ci (ros-controls#440)
608d610 
* Migrate to new industrial_ci

See https://github.com/ros-industrial/industrial_ci/blob/master/doc/migration_guide.md

* Remove deprecated option ROS_PARALLEL_TEST_JOBS

* Update UPSTREAM_WORKSPACE
@bmagyar bmagyar force-pushed the update_CI_for_noetic branch from 271e918 to 1b54a4a Compare April 15, 2020 15:07
@bmagyar bmagyar force-pushed the update_CI_for_noetic branch from 1b54a4a to 63c56cf Compare April 15, 2020 16:18
mathias-luedtke
mathias-luedtke reviewed Apr 16, 2020
View reviewed changes
mathias-luedtke
mathias-luedtke reviewed Apr 16, 2020
View reviewed changes
@bmagyar @mathias-luedtke
Update .travis.yml
6276a1b 
Co-Authored-By: Mathias Lüdtke <[email protected]>
@bmagyar bmagyar force-pushed the update_CI_for_noetic branch from bca69ad to 6276a1b Compare April 17, 2020 11:41
@bmagyar bmagyar requested a review from mathias-luedtke April 20, 2020 15:56
@bmagyar
Copy link
Member Author

bmagyar commented Apr 20, 2020

@ipa-mdl @matthew-reynolds I had to juggle a bunch to get this to pass. The Python2-Python3 switch broke string comparisons in one of the tests I had to chase and it also seems that rostests run from install space which means we have to install most of the test-related stuff.

@bmagyar bmagyar mentioned this pull request Apr 22, 2020
Closed
@bmagyar
Copy link
Member Author

bmagyar commented Apr 22, 2020

I'll go ahead with the merge as thsi is now blocking a bunch of other PR-s. Happy to accomodate any changes post-merge

@bmagyar bmagyar merged commit 42fc925 into ros-controls:noetic-devel Apr 22, 2020
@mikaelarguedas
Copy link
Contributor

This PR seems to have broken deb install on Noetic as now the package installs gtest in a common location that is conflicting with other ROS packages doing the same:

Unpacking ros-noetic-controller-manager-tests (0.19.4-1focal.20201207.152344) ...
dpkg: error processing archive /tmp/apt-dpkg-install-2E6ylt/1076-ros-noetic-controller-manager-tests_0.19.4-1focal.20201207.152344_amd64.deb (--unpack):
 trying to overwrite '/opt/ros/noetic/lib/python3/dist-packages/libgtest.so', which is also in package ros-noetic-tf 1.13.2-1focal.20210112.083534
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)

(I just tried to install ros-noetic-* and am not relying of the deb of this package)

@matthew-reynolds
Copy link
Member

@mikaelarguedas I think this is resolved by ros/catkin#1135 which has finally been merged. Let me know if not and I'll look into if we're doing anything weird here, but I think our CMakeLists are pretty standard.

@mikaelarguedas
Copy link
Contributor

That makes sense, thanks for the pointer 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathias-luedtke mathias-luedtke Awaiting requested review from mathias-luedtke

Assignees
No one assigned
Labels
ROS Noetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmagyar @mikaelarguedas @matthew-reynolds @mathias-luedtke