Fix exception about parameter already been declared & Change default c++ version to 17 #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've experienced this too: 👍 |
|
Same here, thanks for fixing this Jafar! |
RobertWilbrandt
added a commit
to RobertWilbrandt/Universal_Robots_ROS2_Driver
that referenced
this pull request
Jun 21, 2022
ros-controls/ros2_controllers#360 already fixed a bug related to parameter handling in forward controllers. Until next sync we have to use the source repo for error-free controller startup.
fmauch
pushed a commit
to UniversalRobots/Universal_Robots_ROS2_Driver
that referenced
this pull request
Jun 22, 2022
* Use ros2_controllers sources ros-controls/ros2_controllers#360 already fixed a bug related to parameter handling in forward controllers. Until next sync we have to use the source repo for error-free controller startup. * Use ros2_controllers sources for execution tests
mamueluth
pushed a commit
to b-robotized-forks/ros2_controllers
that referenced
this pull request
Aug 26, 2022
…c++ version to 17 (ros-controls#360) * Default C++ version to 17 * Replace explicit use of declare_paremeter with auto_declare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Make the default C++ version to 17 since rclcpp uses features that were introduced in that version https://github.com/ros2/rclcpp/search?q=variant
2- Use auto_declare for
multi_interface_forward_command_controllerandforward_command_controllerto fix the following exceptionException thrown during init stage with message: parameter 'joints' has already been declared