Skip to content

Conversation

rafal-gorecki
Copy link
Contributor

Fix test related with: #1060

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I believe the tests should work as the changes are minimal

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.61%. Comparing base (66d160c) to head (1688fca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files         122      122           
  Lines       11016    11019    +3     
  Branches      933      935    +2     
=======================================
+ Hits         9211     9214    +3     
  Misses       1495     1495           
  Partials      310      310           
Flag Coverage Δ
unittests 83.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 76.98% <100.00%> (+0.46%) ⬆️
...ive_controller/test/test_diff_drive_controller.cpp 93.64% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 10, 2024
@christophfroehlich christophfroehlich merged commit 950c9c1 into ros-controls:master Dec 10, 2024
18 of 20 checks passed
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
Co-authored-by: Kees van Teeffelen <[email protected]>
(cherry picked from commit 950c9c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants