Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rogpeppe/go-internal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.13.1
Choose a base ref
...
head repository: rogpeppe/go-internal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.14.1
Choose a head ref
  • 6 commits
  • 28 files changed
  • 3 contributors

Commits on Oct 8, 2024

  1. Bump Go dependencies

    Signed-off-by: Luca Comellini <[email protected]>
    lucacome authored and mvdan committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e71c486 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2024

  1. Configuration menu
    Copy the full SHA
    f18544a View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2024

  1. testscript: phase out func() int in RunMain

    We wanted the user's command functions to return an exit code as an int
    rather than calling os.Exit directly like a main function
    so that we could collect coverage profiles from subprocesses.
    This way, Go tests using testscript would still report the full
    code coverage information even when using nested processes.
    
    This all thankfully went away with Go 1.20, which introduced the same
    feature but built right into the toolchain for both `go test`
    and `go build`. As such, we were able to drop all of that code,
    including the bit that we ran before os.Exit.
    
    For more information, see:
    https://go.dev/blog/integration-test-coverage
    
    At this point, testscript users continue to use the `func() int`
    signature, via e.g. `func main1() int` out of inertia,
    but there's actually no good reason to keep doing that.
    It causes extra boilerplate and confuses new testscript users.
    Moreover, avoiding the use of os.Exit was rather tricky,
    for example see the former use of flag.ContinueOnExit in our tests.
    
    Add a new API, Main, which uses a `func()` signature just like
    `func main()`, meaning that no second function declaration is needed.
    Deprecate RunMain in favor of Main as well.
    mvdan committed Dec 26, 2024
    Configuration menu
    Copy the full SHA
    a5dc8ff View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2025

  1. add Go 1.24.x, drop 1.22.x

    mvdan committed Feb 24, 2025
    Configuration menu
    Copy the full SHA
    dd6dbb2 View commit details
    Browse the repository at this point in the history
  2. all: modernize -fix ./...

    mvdan committed Feb 24, 2025
    Configuration menu
    Copy the full SHA
    eb18234 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2025

  1. testscript: remove temp dirs when finishing once again

    The recent transition from RunMain to Main meant that we started
    calling os.Exit directly when Main finished.
    However, we failed to spot that os.Exit would make our earlier deferred
    cleanup of the temporary directory not run at all.
    
    Spotted because my /tmp started getting filled up after a few hours
    of development, and I found a suspiciously large number of
    testscript-looking directories.
    mvdan committed Feb 25, 2025
    Configuration menu
    Copy the full SHA
    9ee3698 View commit details
    Browse the repository at this point in the history
Loading