Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3910 #3931

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fix #3910 #3931

merged 3 commits into from
Jan 30, 2024

Conversation

bcolloran
Copy link
Contributor

@bcolloran bcolloran self-assigned this Jan 29, 2024
@ericpgreen2
Copy link
Contributor

It looks like the gradient was removed – it's now just a solid color.

Here's what I'm seeing in TDD:
image

@bcolloran
Copy link
Contributor Author

bcolloran commented Jan 30, 2024

omg you're totally right. it's even missing in the screenshot I took. sorry, I don't know how I missed that. I guess I was just so focused on the opacity that I didn't notice the gradient 👎 :-( fix coming, one sec

@bcolloran
Copy link
Contributor Author

Ok, it's fixed. Sorry I missed this earlier @ericpgreen2

here's what it looks like with the gradient restored:

image

image

and themed:

image

image

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ericpgreen2 ericpgreen2 merged commit addc7ce into main Jan 30, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the adjust-chart-gradient-fix-3910 branch January 30, 2024 02:40
ericpgreen2 pushed a commit that referenced this pull request Jan 31, 2024
* fix #3910

* updates to restore gradient

* final fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust gradient applied to the time series
2 participants