Add state managers under the key by dash name #3900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing issues with stale data from a previously selected dashbaord. This happens when we switch between 2 dashboards that are already opened (this caches data and updates are immediate). Since
StateManagersProvider
is outside the key thestateManagers.setMetricsViewName
is run before the update inmetricsViewName
propagates to the key and the underlying dashboard components are swapped. There is a brief moment when components will have newer data in state managers but local data is stale. This can be seen inFilters.svelte
where we haveactiveDimensionName
.One quick fix is to add the state managers under the key. Another way is to add safeguard everywhere queries are made using data inside a component, but this is not scalable. We should come up with a good fix in the long run.